Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 508D217A09 for ; Thu, 6 Nov 2014 17:12:34 +0000 (UTC) Received: (qmail 33927 invoked by uid 500); 6 Nov 2014 17:12:34 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 33890 invoked by uid 500); 6 Nov 2014 17:12:34 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 33718 invoked by uid 99); 6 Nov 2014 17:12:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Nov 2014 17:12:34 +0000 Date: Thu, 6 Nov 2014 17:12:34 +0000 (UTC) From: "Josh Elser (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-3306) Consider removing port-guess portion of PortUtils.getRandomFreePort MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200477#comment-14200477 ] Josh Elser commented on ACCUMULO-3306: -------------------------------------- Also, I just noticed that PortUtils.getRandomFreePort also doesn't increment {{count}} that it uses to not loop indefinitely. > Consider removing port-guess portion of PortUtils.getRandomFreePort > ------------------------------------------------------------------- > > Key: ACCUMULO-3306 > URL: https://issues.apache.org/jira/browse/ACCUMULO-3306 > Project: Accumulo > Issue Type: Improvement > Affects Versions: 1.6.1 > Reporter: Josh Elser > Assignee: Josh Elser > Fix For: 1.6.2, 1.7.0 > > > I recently changed how SimpleMacIT and ConfigurableMacIT start the mini cluster in an attempt to mitigate ZooKeeper failing to start when the port we guessed at was already in use. In last night's run of integration tests on master, we had 22 occurrences of the warning ("Failed to start MiniAccumuloCluster, assumably due to ZooKeeper issues"). > I'm wondering if we can do anything to getRandomFreePort to make it more reliable. Would not providing a port (0) and letting it find one for itself be more stable? -- This message was sent by Atlassian JIRA (v6.3.4#6332)