accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3321) Log exceptions in ThriftScanner#getBatchFromServer as warnings/errors
Date Mon, 10 Nov 2014 05:25:33 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14204361#comment-14204361
] 

ASF GitHub Bot commented on ACCUMULO-3321:
------------------------------------------

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/18#discussion_r20067167
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/ThriftScanner.java ---
    @@ -115,12 +115,12 @@ public static boolean getBatchFromServer(Instance instance, Credentials
credenti
         } catch (TApplicationException tae) {
           throw new AccumuloServerException(server, tae);
         } catch (TooManyFilesException e) {
    -      log.debug("Tablet (" + extent + ") has too many files " + server + " : " + e);
    +      log.warn("Tablet (" + extent + ") has too many files " + server + " : " + e);
         } catch (ThriftSecurityException e) {
           log.warn("Security Violation in scan request to " + server + ": " + e);
           throw new AccumuloSecurityException(e.user, e.code, e);
         } catch (TException e) {
    -      log.debug("Error getting transport to " + server + " : " + e);
    +      log.warn("Error getting transport to " + server + " : " + e);
    --- End diff --
    
    This is tricky. In the case that a tserver fails, this would cause logging on the client.
Ideally, the system will recover from a tserver failure and the client wouldn't even have
to know that a failure happened. Might it make more sense to leave this at debug for the first
N occurrences for a server and then elevate it to warn at the N+1th time?


> Log exceptions in ThriftScanner#getBatchFromServer as warnings/errors 
> ----------------------------------------------------------------------
>
>                 Key: ACCUMULO-3321
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3321
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>            Reporter: Ariel Valentin
>            Priority: Minor
>
> While trying to debug an issue with a client that seemed unresponsive I increased the
log lever to debug and found that we were experiencing DNS failures:
> {code}
> 22:14:53,549 DEBUG [org.apache.zookeeper.ClientCnxn] (http-/192.168.220.198:8080-1-SendThread(ZKHOST:2181))
Reading reply sessionid:0x1498bc00431010f, packet:: clientPath:null serverPath:null finished:false
header:: 414,3  replyHeader:: 414,107374188046,0  request:: '/accumulo/4663a372-d7f0-4956-a110-ff063c781ead/tservers/TSERVER_HOST:10011/zlock-0000000036,T
 response:: s{107374187891,107374187891,1415398174207,1415398174207,0,0,0,92758924158107923,33,0,107374187891}

> 22:14:53,922 DEBUG [org.apache.zookeeper.ClientCnxn] (http-/192.168.220.198:8080-1-SendThread(ZKHOST:2181))
Reading reply sessionid:0x1498bc00431010f, packet:: clientPath:null serverPath:null finished:false
header:: 415,4  replyHeader:: 415,107374188046,0  request:: '/accumulo/4663a372-d7f0-4956-a110-ff063c781ead/tservers/TSERVER_HOST:10011/zlock-0000000036,T
 response:: #54534552565f434c49454e543d7330322d6265732d646e6f6436323a3130303131,s{107374187891,107374187891,1415398174207,1415398174207,0,0,0,92758924158107923,33,0,107374187891}

> 22:14:53,936 DEBUG [org.apache.accumulo.core.client.impl.ThriftScanner] (http-/192.168.220.198:8080-1)
Error getting transport to TSERVER_HOST:10011 : org.apache.thrift.transport.TTransportException:
java.net.UnknownHostException
> {code}
> There is another exception that is logged at debug in getBatchFromServer and I would
like these messages to log at WARN or ERROR level. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message