Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CB04A17666 for ; Wed, 29 Oct 2014 02:22:33 +0000 (UTC) Received: (qmail 37972 invoked by uid 500); 29 Oct 2014 02:22:33 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 37934 invoked by uid 500); 29 Oct 2014 02:22:33 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 37919 invoked by uid 99); 29 Oct 2014 02:22:33 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Oct 2014 02:22:33 +0000 Date: Wed, 29 Oct 2014 02:22:33 +0000 (UTC) From: "Josh Elser (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (ACCUMULO-3274) MinorCompactor repeatedly toString()'s outputFile MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Josh Elser created ACCUMULO-3274: ------------------------------------ Summary: MinorCompactor repeatedly toString()'s outputFile Key: ACCUMULO-3274 URL: https://issues.apache.org/jira/browse/ACCUMULO-3274 Project: Accumulo Issue Type: Improvement Components: tserver Affects Versions: 1.6.1 Reporter: Josh Elser Fix For: 1.7.0 Noticed that {{MinorCompactor#call()}} repeatedly calls {{getOutputFile()}} which ultimately calls {{Path#toString()}} each time. This isn't very efficient since we're repeatedly calculating the same thing and creating a bunch of short-lived objects. The output file name isn't going to change mid-MinC so the MinorCompactor should keep a local referenced to the result from a single call to {{getOutputFile()}} and use that local variable each time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)