accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3274) MinorCompactor repeatedly toString()'s outputFile
Date Wed, 29 Oct 2014 02:24:33 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187911#comment-14187911
] 

Josh Elser commented on ACCUMULO-3274:
--------------------------------------

{{Compactor#call()}} does a similar thing and could benefit from the same improvement.

> MinorCompactor repeatedly toString()'s outputFile
> -------------------------------------------------
>
>                 Key: ACCUMULO-3274
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3274
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: tserver
>    Affects Versions: 1.6.1
>            Reporter: Josh Elser
>              Labels: newbie
>             Fix For: 1.7.0
>
>
> Noticed that {{MinorCompactor#call()}} repeatedly calls {{getOutputFile()}} which ultimately
calls {{Path#toString()}} each time. This isn't very efficient since we're repeatedly calculating
the same thing and creating a bunch of short-lived objects.
> The output file name isn't going to change mid-MinC so the MinorCompactor should keep
a local referenced to the result from a single call to {{getOutputFile()}} and use that local
variable each time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message