accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ACCUMULO-3274) MinorCompactor repeatedly toString()'s outputFile
Date Wed, 29 Oct 2014 02:22:33 GMT
Josh Elser created ACCUMULO-3274:
------------------------------------

             Summary: MinorCompactor repeatedly toString()'s outputFile
                 Key: ACCUMULO-3274
                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3274
             Project: Accumulo
          Issue Type: Improvement
          Components: tserver
    Affects Versions: 1.6.1
            Reporter: Josh Elser
             Fix For: 1.7.0


Noticed that {{MinorCompactor#call()}} repeatedly calls {{getOutputFile()}} which ultimately
calls {{Path#toString()}} each time. This isn't very efficient since we're repeatedly calculating
the same thing and creating a bunch of short-lived objects.

The output file name isn't going to change mid-MinC so the MinorCompactor should keep a local
referenced to the result from a single call to {{getOutputFile()}} and use that local variable
each time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message