accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3224) Shell should use nanos for auth timeout
Date Fri, 10 Oct 2014 20:43:33 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167474#comment-14167474
] 

Josh Elser commented on ACCUMULO-3224:
--------------------------------------

Would be much preferred if you could not commit all of the formatting changes with the actual
changes (make the formatting changes in another issue specifically for that, if you'd like).
If there is some reason we need to look back at these changes, getting at the actually changes
would be nice.

Otherwise, LGTM.

> Shell should use nanos for auth timeout
> ---------------------------------------
>
>                 Key: ACCUMULO-3224
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3224
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: shell
>            Reporter: Christopher Tubbs
>            Assignee: Christopher Tubbs
>             Fix For: 1.5.3, 1.6.2, 1.7.0
>
>         Attachments: 0001-ACCUMULO-3224-Use-nanoTime-in-the-shell-s-auth-timeo.patch
>
>
> I was looking at the code done for ACCUMULO-3221 and noticed that we're using the system
clock instead of the JDK's internal relative time, System.nanoTime(). This is a problem, because
any auth timeout that depends on the system clock can be easily bypassed by changing the system
time.
> We can also do the time conversion more reliably with {{TimeUnit}} to avoid the potential
arithmetic bug identified in ACCUMULO-3221.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message