accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <>
Subject [jira] [Updated] (ACCUMULO-3181) VolumeChooser usage doesn't always comply with implied API contract
Date Wed, 29 Oct 2014 08:00:55 GMT


Sean Busbey updated ACCUMULO-3181:
    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Pushed to 1.6 and master. Thanks for sticking through this Jenna!

[~elserj], per your request I ran through all the ITs.

* on 1.6 ExistingMacIT failed before and after (ACCUMULO-3255)
* master had the same error, additionally the SSL ITs failed before and after (ACCUMULO-3252)
and WaitForBalanceIT timed out before and after. I had to run with non-default timeout.factor
to have UnorderedWorkAssignerReplicationIT and MultiInstanceReplicationIT pass.

> VolumeChooser usage doesn't always comply with implied API contract
> -------------------------------------------------------------------
>                 Key: ACCUMULO-3181
>                 URL:
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.6.0, 1.6.1
>            Reporter: Christopher Tubbs
>            Assignee: Jenna Huston
>              Labels: api, interface, plugin
>             Fix For: 1.6.2, 1.7.0
>         Attachments: 0001-ACCUMULO-3181-VolumeChooser-usage-doesn-t-always-com.patch
>          Time Spent: 20m
>  Remaining Estimate: 0h
> The VolumeChooser interface accepts a String array of "options" to choose from. This
method has no javadoc to explicitly declare what "options" mean, but given the name of the
class, and its intended purpose, derived from its usage, it appears that the Strings it receives
should represent volumes.
> However, some of the current usage is a bit lax in its parameter passing. In some cases,
what is passed are not volumes at all, but volumes concatenated with some path. This works
for the RandomVolumeChooser provided, but it should not be expected to work for any arbitrary
> The use of this API should consider the parameter to strictly be an array of volumes
(or Strings, representing volumes), since it's not a "PathChooser". Any concatenation of path
elements should be done outside the chooser, so we can define the API contract explicitly.
That means that some of the current usage should be altered to concatenate path elements after
the choose method returns.

This message was sent by Atlassian JIRA

View raw message