accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-898) look into replacing cloudtrace
Date Thu, 09 Oct 2014 21:21:36 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165764#comment-14165764
] 

Christopher Tubbs commented on ACCUMULO-898:
--------------------------------------------

Skimmed through the patch today, and had a couple of thoughts/issues:

# The patch wouldn't apply cleanly with {{git am}}
# The patch introduces new warnings (mostly generics, unused imports, one resource leak creating
a new {{TraceScope}} that isn't closed in the {{AccumuloReplicationSystem}})
# Ideally, the patch should remove the {{accumulo-trace}} module entirely, in favor of the
dependency on the {{htrace}} library; only the {{accumulo-tracer}} module should be left.
# Utility classes for registering {{SpanReceivers}} can be in {{accumulo-core}} ({{o.a.a.core.util}}).
# Since the {{SpanReceivers}} and related utilities are associated with the {{accumulo-tracer}}
service, they should probably be moved there.
# I'm not sure I understand the distinction in roles the {{SpanReceiverHost}} is supposed
to serve, vs. the {{TraceUtil}}.
# The dependency on the Hadoop configuration should be changed, because Accumulo services
(and particularly Accumulo clients) should not depend on Hadoop config. It is reasonable to
have Hadoop's SpanReceivers set to the same as Accumulo's, but we should practice good separation
of responsibilities, and leave that choice up to the administrator.

> look into replacing cloudtrace
> ------------------------------
>
>                 Key: ACCUMULO-898
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-898
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Eric Newton
>            Assignee: James Fiori
>             Fix For: 1.7.0
>
>         Attachments: ACCUMULO-898-1.patch, Cloudtrace Replacement Design Doc.pdf, trace-tracer.png,
trace-zipkin.png
>
>
> HBase has created their own distributed tracing library, and today I bumped into zipkin.
 zipkin has a reasonable visualization, and seems to work with thrift.  We should look into
replacing our tracing with one of these.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message