Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Wed, 24 Sep 2014 17:39:35 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12737522.1409248454000.113783.1411580375666@Atlassian.JIRA>
In-Reply-To: <JIRA.12737522.1409248454000@Atlassian.JIRA>
References: <JIRA.12737522.1409248454000@Atlassian.JIRA>
 <JIRA.12737522.1409248454336@arcas>
Subject: [jira] [Commented] (ACCUMULO-3089) Create a volume chooser that
 makes decisions based on table attributes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ACCUMULO-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146585#comment-14146585 ] 

ASF GitHub Bot commented on ACCUMULO-3089:
------------------------------------------

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/16#discussion_r17987075
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java ---
    @@ -103,6 +103,25 @@
       void create(String tableName, boolean versioningIter, TimeType timeType) throws AccumuloException, AccumuloSecurityException, TableExistsException;
     
       /**
    +   * @param tableName
    +   *          the name of the table
    +   * @param limitVersion
    +   *          Enables/disables the versioning iterator, which will limit the number of Key versions kept.
    +   * @param timeType
    +   *          specifies logical or real-time based time recording for entries in the table
    +   * @param properties
    +   *          initial table properties the user wants
    +   * @throws AccumuloException
    +   *           if a general error occurs
    +   * @throws AccumuloSecurityException
    +   *           if the user does not have permission
    +   * @throws TableExistsException
    +   *           if the table already exists
    +   */
    +  void create(String tableName, boolean limitVersion, TimeType timeType, Map<String,String> properties) throws AccumuloException, AccumuloSecurityException,
    --- End diff --
    
    Instead of introducing yet another create table method, we could create a NewTableConfiguration class and pass that.
    
    ```java
    public class NewTableConfiguration {
      public NewTableConfiguration setTimeType(TimeType tt){...}
      public NewTableConfiguration setLimitVersions(boolean lv){...}
      public NewTableConfiguration setProperties(Map<String,String> properties){...}
    }
    ```
    
    And add a method like the following, and possibly deprecated existing create table methods (except for create(String) )
    
    ```java
     void create(String tableName, NewTableConfig ntc)
    ```


> Create a volume chooser that makes decisions based on table attributes
> ----------------------------------------------------------------------
>
>                 Key: ACCUMULO-3089
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3089
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Christopher Tubbs
>            Assignee: Jenna Huston
>
> Use case:
> User provisions multiple volumes, some with tmpfs drives, some with SSDs, some with traditional magnetic spindle hard drives. A volume chooser could use attribute information on tables (ACCUMULO-2841) to decide which volume to choose when creating new tablets.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)