accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-3089) Create a volume chooser that makes decisions based on table attributes
Date Fri, 26 Sep 2014 17:02:34 GMT


ASF GitHub Bot commented on ACCUMULO-3089:

Github user ctubbsii commented on a diff in the pull request:
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/ ---
    @@ -18,5 +18,7 @@
     public interface VolumeChooser {
    +  String choose(VolumeChooserEnvironment env, String[] options);
    --- End diff --
    Right, this will break the interface. This is low risk, I think, though. The VolumeChooser
isn't part of the public API (yet), is it? The alternative is that we can pass the environment
with dependency injection to an annotated field, if it exists. If this is something that's
a blocker, that's an option.
    There's also a slight behavioral change to consider here (improvement, I think) that may
be relevant, if we're concerned about API. The original VolumeChooser interface did not choose
between volumes.... it chose between paths. This patch changes things so that the API conforms
to the user expectations that it will be provided with volumes from which to choose, which
the framework will append any necessary paths to, if needed.

> Create a volume chooser that makes decisions based on table attributes
> ----------------------------------------------------------------------
>                 Key: ACCUMULO-3089
>                 URL:
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Christopher Tubbs
>            Assignee: Jenna Huston
> Use case:
> User provisions multiple volumes, some with tmpfs drives, some with SSDs, some with traditional
magnetic spindle hard drives. A volume chooser could use attribute information on tables (ACCUMULO-2841)
to decide which volume to choose when creating new tablets.

This message was sent by Atlassian JIRA

View raw message