accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3089) Create a volume chooser that makes decisions based on table attributes
Date Fri, 26 Sep 2014 04:57:34 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148772#comment-14148772
] 

ASF GitHub Bot commented on ACCUMULO-3089:
------------------------------------------

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/16#discussion_r18073784
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java ---
    @@ -261,7 +263,8 @@ private static String decommisionedTabletDir(ZooLock zooLock, VolumeManager
vm,
           throw new IllegalArgumentException("Unexpected table dir " + dir);
         }
     
    -    Path newDir = new Path(vm.choose(ServerConstants.getTablesDirs()) + "/" + dir.getParent().getName()
+ "/" + dir.getName());
    +    Path newDir = new Path(vm.choose(Optional.of(extent.getTableId().toString()), ServerConstants.getTablesDirs())
+ "/tables/" + dir.getParent().getName()
    --- End diff --
    
    You added an extra "tables" to the constructed `Path`. Was that intentional? Doesn't `ServerConstants.getTablesDirs()`
give this to you already?


> Create a volume chooser that makes decisions based on table attributes
> ----------------------------------------------------------------------
>
>                 Key: ACCUMULO-3089
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3089
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Christopher Tubbs
>            Assignee: Jenna Huston
>
> Use case:
> User provisions multiple volumes, some with tmpfs drives, some with SSDs, some with traditional
magnetic spindle hard drives. A volume chooser could use attribute information on tables (ACCUMULO-2841)
to decide which volume to choose when creating new tablets.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message