accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3089) Create a volume chooser that makes decisions based on table attributes
Date Fri, 26 Sep 2014 04:45:34 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148754#comment-14148754
] 

ASF GitHub Bot commented on ACCUMULO-3089:
------------------------------------------

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/16#discussion_r18073602
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/GeneralVolumeChooser.java
---
    @@ -0,0 +1,60 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.server.fs;
    +
    +import java.util.Map;
    +
    +import org.apache.accumulo.core.conf.AccumuloConfiguration.AllFilter;
    +import org.apache.accumulo.core.conf.AccumuloConfiguration.PropertyFilter;
    +import org.apache.accumulo.start.classloader.vfs.AccumuloVFSClassLoader;
    +import org.apache.log4j.Logger;
    +
    +public class GeneralVolumeChooser implements VolumeChooser {
    +  private static final Logger log = Logger.getLogger(GeneralVolumeChooser.class);
    +
    +  public GeneralVolumeChooser() {}
    +
    +  @Override
    +  public String choose(VolumeChooserEnvironment env, String[] options) {
    +    String clazzName = new String();
    +    try {
    +      // Get the current table's properties, and find the chooser property
    +      PropertyFilter filter = new AllFilter();
    +      Map<String,String> props = new java.util.HashMap<String,String>();
    +      env.getProperties(props, filter);
    +
    +      clazzName = props.get("table.custom.chooser");
    +      log.info("TableID: " + env.getTableId() + " ClassName: " + clazzName);
    +
    +      // Load the correct chooser and create an instance of it
    +      Class<? extends VolumeChooser> clazz = AccumuloVFSClassLoader.loadClass(clazzName,
VolumeChooser.class);
    +      VolumeChooser instance = clazz.newInstance();
    +      // Choose the volume based using the created chooser
    +      return instance.choose(env, options);
    +    } catch (Exception e) {
    +      // If an exception occurs, first write a warning and then use a default RandomVolumeChooser
to choose from the given options
    +      log.warn(e, e);
    +      return new RandomVolumeChooser().choose(options);
    --- End diff --
    
    IMO, it's much better to fail hard and fast if the configuration is busted (or the classpath
is missing necessary classes). It may require some better, graceful error handling in the
caller, but we can help figure that out. 


> Create a volume chooser that makes decisions based on table attributes
> ----------------------------------------------------------------------
>
>                 Key: ACCUMULO-3089
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3089
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Christopher Tubbs
>            Assignee: Jenna Huston
>
> Use case:
> User provisions multiple volumes, some with tmpfs drives, some with SSDs, some with traditional
magnetic spindle hard drives. A volume chooser could use attribute information on tables (ACCUMULO-2841)
to decide which volume to choose when creating new tablets.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message