accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3089) Create a volume chooser that makes decisions based on table attributes
Date Wed, 24 Sep 2014 17:54:34 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14146608#comment-14146608
] 

ASF GitHub Bot commented on ACCUMULO-3089:
------------------------------------------

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/16#discussion_r17987986
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java
---
    @@ -560,8 +565,22 @@ public ContentSummary getContentSummary(Path dir) throws IOException
{
       }
     
       @Override
    -  public String choose(String[] options) {
    -    return chooser.choose(options);
    +  public String choose(Optional<String> tableId, String[] options) {
    +    // If the tableId is present, use that to create a VolumeChooserEnvironment variable
    +    if (tableId.isPresent()) {
    +      // Get the current instance and from that the ServerConfigurationFactory and in
turn the tableId
    +      Instance instance = HdfsZooInstance.getInstance();
    +      ServerConfigurationFactory serverConf = new ServerConfigurationFactory(instance);
    +      TableConfiguration tableConf = serverConf.getTableConfiguration(tableId.get());
    +
    +      // Create the environment and then choose the volume using the currently defined
chooser
    +      VolumeChooserEnvironment env = new VolumeChooserEnvironment(tableConf);
    +      return chooser.choose(env, options);
    +    } else {
    +      // If the tableId is missing, then just choose using the current chooser, without
using the per table properties
    +      log.info("TABLE ID MISSING");
    --- End diff --
    
    this is not a very useful log message, and I assume it will occur regularly in the case
when a volume is chosen for walogs... maybe drop it


> Create a volume chooser that makes decisions based on table attributes
> ----------------------------------------------------------------------
>
>                 Key: ACCUMULO-3089
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3089
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Christopher Tubbs
>            Assignee: Jenna Huston
>
> Use case:
> User provisions multiple volumes, some with tmpfs drives, some with SSDs, some with traditional
magnetic spindle hard drives. A volume chooser could use attribute information on tables (ACCUMULO-2841)
to decide which volume to choose when creating new tablets.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message