Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Fri, 22 Aug 2014 23:34:11 +0000 (UTC)
From: "Christopher Tubbs (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12736202.1408750434271.17626.1408750451451@arcas>
In-Reply-To: <JIRA.12736202.1408750434271@arcas>
References: <JIRA.12736202.1408750434271@arcas>
Subject: [jira] [Created] (ACCUMULO-3081) ServerConfigurationFactoryTest is
 full of commented out and unused code
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Christopher Tubbs created ACCUMULO-3081:
-------------------------------------------

             Summary: ServerConfigurationFactoryTest is full of commented out and unused code
                 Key: ACCUMULO-3081
                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3081
             Project: Accumulo
          Issue Type: Sub-task
            Reporter: Christopher Tubbs
            Priority: Minor
             Fix For: 1.6.1, 1.7.0


Commented out code is not good to leave in. It creates readability and maintainability problems, such as questions about how current it is, and whether the reasons for commenting it out are still valid.

This code should be removed from ServerConfigurationFactoryTest.

If there is a unit test which is broken in some way and needs to be disabled until some other problem is fixed, it should reference the relevant JIRA (ideally, which references the relevant code in return, so any contributor working on that issue knows it's there) and use the @Ignore annotation to disable.


--
This message was sent by Atlassian JIRA
(v6.2#6252)