Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Wed, 13 Aug 2014 14:54:15 +0000 (UTC)
From: "Bill Havanki (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12729308.1406160431983.72217.1407941655028@arcas>
In-Reply-To: <JIRA.12729308.1406160431983@arcas>
References: <JIRA.12729308.1406160431983@arcas>
Subject: [jira] [Updated] (ACCUMULO-3012) Simplify DefaultConfiguration
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/ACCUMULO-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bill Havanki updated ACCUMULO-3012:
-----------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

After a delay, committed reviewed changes.

Reminder: there were two commits here, one for 1.5.x and one for 1.6.x. I did a merge -sours from 1.5.2-SNAPSHOT to 1.6.1-SNAPSHOT before committing the 1.6.x-specific change, so hopefully the history is tied up nicely.

Note: after committing, I noticed that I also fixed the usage statement for {{main()}} in {{DefaultConfiguration}} moved to {{ConfigurationDocGen}} - it still specified the option "generate-latex" instead of "generate-asciidoc". (See ACCUMULO-1327.)

> Simplify DefaultConfiguration
> -----------------------------
>
>                 Key: ACCUMULO-3012
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3012
>             Project: Accumulo
>          Issue Type: Sub-task
>            Reporter: Bill Havanki
>            Assignee: Bill Havanki
>            Priority: Minor
>             Fix For: 1.5.2, 1.6.1, 1.7.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> The current implementation of {{DefaultConfiguration}} has some downsides:
> * Its internal map of configuration defaults is built on-demand in its singleton instance, which drives the need to synchronize access to the singleton. The map could be built statically.
> * That same map could be made immutable as well.
> * Even though it uses a singleton, {{new DefaultConfiguration()}} is still permitted since the no-arg constructor isn't defined as private.
> * Calls to {{DefaultConfiguration.getInstance()}} cannot be easily mocked.
> * Its main method no longer has anything to do with it, and instead belongs in {{ConfigurationDocGen}}.
> Improve and simplify {{DefaultConfiguration}}.


--
This message was sent by Atlassian JIRA
(v6.2#6252)