Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6DF79117BE for ; Fri, 1 Aug 2014 18:45:39 +0000 (UTC) Received: (qmail 36100 invoked by uid 500); 1 Aug 2014 18:45:39 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 36066 invoked by uid 500); 1 Aug 2014 18:45:39 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 35939 invoked by uid 99); 1 Aug 2014 18:45:39 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Aug 2014 18:45:39 +0000 Date: Fri, 1 Aug 2014 18:45:39 +0000 (UTC) From: "Eric Newton (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (ACCUMULO-2615) Simplify server configuration caching and ZK watchers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Newton resolved ACCUMULO-2615. ----------------------------------- Resolution: Fixed > Simplify server configuration caching and ZK watchers > ----------------------------------------------------- > > Key: ACCUMULO-2615 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2615 > Project: Accumulo > Issue Type: Improvement > Reporter: Bill Havanki > Assignee: Eric Newton > Fix For: 1.6.1, 1.7.0 > > Time Spent: 1h > Remaining Estimate: 0h > > The mechanism used for caching server-related configuration objects and processing ZK events could do with some simplification. For example: > * The watcher objects obtain their corresponding configuration objects by reaching through the {{ServerConfiguration}} cache, instead of just having a more direct reference. > * The watcher objects set log4j logging levels for both ZK and o.a.hadoop.io.compress to WARN, which prohibits debugging when needed. That should be done in log4j properties/XML instead. > * Possible bug: {{NamespaceConfWatcher}} expires table configuration observers, not namespace configuration observers. > * There is high duplication between the static and instance methods of {{ServerConfiguration}}. The class serves as both a cache container and a factory. Moreover, despite its name, it isn't actually a configuration object. > I may be missing some subtleties of why things are as they are, so please fill me in as needed. -- This message was sent by Atlassian JIRA (v6.2#6252)