accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (ACCUMULO-3081) ServerConfigurationFactoryTest is full of commented out and unused code
Date Sat, 23 Aug 2014 00:46:12 GMT

     [ https://issues.apache.org/jira/browse/ACCUMULO-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Christopher Tubbs resolved ACCUMULO-3081.
-----------------------------------------

    Resolution: Fixed

> ServerConfigurationFactoryTest is full of commented out and unused code
> -----------------------------------------------------------------------
>
>                 Key: ACCUMULO-3081
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3081
>             Project: Accumulo
>          Issue Type: Sub-task
>            Reporter: Christopher Tubbs
>            Assignee: Christopher Tubbs
>            Priority: Minor
>             Fix For: 1.6.1, 1.7.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Commented out code is not good to leave in. It creates readability and maintainability
problems, such as questions about how current it is, and whether the reasons for commenting
it out are still valid.
> This code should be removed from ServerConfigurationFactoryTest.
> If there is a unit test which is broken in some way and needs to be disabled until some
other problem is fixed, it should reference the relevant JIRA (ideally, which references the
relevant code in return, so any contributor working on that issue knows it's there) and use
the @Ignore annotation to disable.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message