Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Thu, 24 Jul 2014 00:08:44 +0000 (UTC)
From: "Bill Havanki (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12729308.1406160431983.34056.1406160524135@arcas>
In-Reply-To: <JIRA.12729308.1406160431983@arcas>
References: <JIRA.12729308.1406160431983@arcas>
Subject: [jira] [Created] (ACCUMULO-3012) Simplify DefaultConfiguration
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Bill Havanki created ACCUMULO-3012:
--------------------------------------

             Summary: Simplify DefaultConfiguration
                 Key: ACCUMULO-3012
                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3012
             Project: Accumulo
          Issue Type: Sub-task
            Reporter: Bill Havanki
            Assignee: Bill Havanki
            Priority: Minor
             Fix For: 1.6.1, 1.7.0


The current implementation of {{DefaultConfiguration}} has some downsides:

* Its internal map of configuration defaults is built on-demand in its singleton instance, which drives the need to synchronize access to the singleton. The map could be built statically.
* That same map could be made immutable as well.
* Even though it uses a singleton, {{new DefaultConfiguration()}} is still permitted since the no-arg constructor isn't defined as private.
* Calls to {{DefaultConfiguration.getInstance()}} cannot be easily mocked.
* Its main method no longer has anything to do with it, and instead belongs in {{ConfigurationDocGen}}.

Improve and simplify {{DefaultConfiguration}}.


--
This message was sent by Atlassian JIRA
(v6.2#6252)