accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3019) Fix ServerConfiguration deprecation
Date Fri, 25 Jul 2014 13:53:40 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074407#comment-14074407
] 

Bill Havanki commented on ACCUMULO-3019:
----------------------------------------

+1 on undeprecating {{ServerConfiguration}}. Sorry about the warnings.

IMO a "ServerConfiguration" object should be some sort of configuration object, so I'm not
in favor of having the factory implement it.

I'm happy to work with you on figuring out some solution for the plugins. {{ServerConfiguration}}
isn't part of the public API, though, is it? To what extent can we practically adjust it?

I'm working on the static {{SiteConfiguration}} calls under ACCUMULO-2603. A complicating
factor is that {{SiteConfiguration}} sort of belongs in o.a.a.server.conf and not the core,
as [~ctubbsii] explained in ACCUMULO-2992, but I'm not planning to address that in the near
term.

> Fix ServerConfiguration deprecation
> -----------------------------------
>
>                 Key: ACCUMULO-3019
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3019
>             Project: Accumulo
>          Issue Type: Sub-task
>          Components: master, tserver
>            Reporter: Eric Newton
>            Assignee: Eric Newton
>             Fix For: 1.7.0
>
>
> The deprecation of ServerConfiguration causes two problems:
> 1) eclipse is showing me ~300 warnings, so I'm missing other warnings in the noise
> 2) ServerConfiguration is passed to some plug-ins (Balancer, at least), so any existing
plug-ins are broken by the change.
> In the past, I would have been fine with just switching to the new class {{ServerConfigurationFactory}}
but a growing user base and petabytes of existing systems gives me pause.
> Instead, I'm thinking we hoist the most popular methods to an abstract ServerConfiguration,
and provide ServerConfiguationFactory as the implementation.  This way the extensions continue
to work.
> I'm still not sure what to do about static calls to get the SiteConfiguration.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message