accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3012) Simplify DefaultConfiguration
Date Fri, 25 Jul 2014 15:25:38 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074472#comment-14074472
] 

Josh Elser commented on ACCUMULO-3012:
--------------------------------------

[~bhavanki], at first glance, if you're going to make these changes for 1.6.1, I'd also like
to see them done for 1.5.2. Otherwise, I think we should just keep this for 1.7.0. Thoughts?

> Simplify DefaultConfiguration
> -----------------------------
>
>                 Key: ACCUMULO-3012
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3012
>             Project: Accumulo
>          Issue Type: Sub-task
>            Reporter: Bill Havanki
>            Assignee: Bill Havanki
>            Priority: Minor
>             Fix For: 1.6.1, 1.7.0
>
>
> The current implementation of {{DefaultConfiguration}} has some downsides:
> * Its internal map of configuration defaults is built on-demand in its singleton instance,
which drives the need to synchronize access to the singleton. The map could be built statically.
> * That same map could be made immutable as well.
> * Even though it uses a singleton, {{new DefaultConfiguration()}} is still permitted
since the no-arg constructor isn't defined as private.
> * Calls to {{DefaultConfiguration.getInstance()}} cannot be easily mocked.
> * Its main method no longer has anything to do with it, and instead belongs in {{ConfigurationDocGen}}.
> Improve and simplify {{DefaultConfiguration}}.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message