accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-3006) Don't allow viewfs in instance.volumes
Date Tue, 22 Jul 2014 20:36:39 GMT


Christopher Tubbs commented on ACCUMULO-3006:

My additions:

+1 to #1

Re #2 and to clarify, my point about transparency is that Accumulo uses the Hadoop API, and
cannot be reasonably expected to know that any particular implementation has quirky or incomplete
behavior. However, I concede that adding some vetting of known good URI schemes for volumes
might be appropriate, due to the fact that some diverge from the API contract significantly
(either because things are left unimplemented, or because they diverge from expected behavior).
In particular, I like the "init" and "init --add-volumes" check of the URIs in instance.volumes
for known good schemes *(which we'll just assume map to known good FileSystem implementations),
and should fail if it doesn't match, with a message describing an override option.

For upgrades, there's no init, hence the suggestion to add a warning to start. However, I'm
not so sure this is a FileSystem-specific problem so much as a problem with the fact that
the instance.volumes is set, in an upgrade, to something which is not equivalent to the deprecated
fields left from the previous version (either blank or dfs.uri + dfs.dir). That's the real
problem for upgrades, and that's probably what we should be checking for in the upgrade code.

> Don't allow viewfs in instance.volumes
> --------------------------------------
>                 Key: ACCUMULO-3006
>                 URL:
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.6.0
>            Reporter: Dave Marion
>            Priority: Blocker
>             Fix For: 1.6.1, 1.7.0
> I think one of our folks put viewfs into instance.volumes on accident. File references
in accumulo.root and accumulo.metadata were then written with viewfs in the path. The garbage
collector then throws errors as compactions occur and it tries delete and move the files to
the hdfs users trash directory.
> viewfs should never be allowed in instance.volumes property. It should fail.

This message was sent by Atlassian JIRA

View raw message