accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Vines (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (ACCUMULO-2623) AbstractMetricsImpl's toString is excessively verbose
Date Tue, 08 Jul 2014 15:54:05 GMT

     [ https://issues.apache.org/jira/browse/ACCUMULO-2623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

John Vines resolved ACCUMULO-2623.
----------------------------------

    Resolution: Fixed

Switched to using SHORT_PREFIX_STYLE for the ToStringBuilder, which lops off the package info
and the hash code for an object. Now makes a line show up like {code}20140708114739EDT Metric:
idle: AbstractMetricsImpl.Metric[count=1570,average=811,minimum=0,maximum=2715]
{code}

> AbstractMetricsImpl's toString is excessively verbose
> -----------------------------------------------------
>
>                 Key: ACCUMULO-2623
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2623
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: tserver
>    Affects Versions: 1.5.0, 1.5.1
>            Reporter: John Vines
>            Assignee: John Vines
>              Labels: newbie
>             Fix For: 1.5.2, 1.6.1, 1.7.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> AbstractMetricsImpl, which handles all the metrics logging in the tserver (maybe master
too), does it's logging via it's toString method. This is built from a StringBuilder, starting
with the commons-lang ToStringBuilder utility which spits out the class name, hash code, and
and content start. This information, I feel, is useless (except class name), so we should
trim down the information included.
> Otherwise, you get lines like this-
> {code}20140403115847CDT Metric: commitPrep: org.apache.accumulo.server.metrics.AbstractMetricsImpl$Metric@49c237ca[count=2164,average=0,minimum=0,maximum=138]
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message