Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D5C2B11289 for ; Thu, 26 Jun 2014 20:35:27 +0000 (UTC) Received: (qmail 2305 invoked by uid 500); 26 Jun 2014 20:35:27 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 2268 invoked by uid 500); 26 Jun 2014 20:35:27 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 2257 invoked by uid 99); 26 Jun 2014 20:35:27 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Jun 2014 20:35:27 +0000 Date: Thu, 26 Jun 2014 20:35:27 +0000 (UTC) From: "Josh Elser (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-2877) CachedConfiguration.setInstance never used outside class MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14045124#comment-14045124 ] Josh Elser commented on ACCUMULO-2877: -------------------------------------- bq. If the client API does not call CachedConfiguration, then the method is not necessary. We could re-open ACCUMULO-43. Would it make sense for public API methods that interact directly with HDFS ({{TableOperationsImpl#importDirectory}}) to accept a Configuration object? We could add that support moving forward, deprecate the version that relies on CachedConfiguration, and then have a clear time when we can remove CachedConfiguration. It looks like OfflineScanner could also benefit from the same approach (although we could create a Configuration with the relevant information from accumulo-site.xml too). > CachedConfiguration.setInstance never used outside class > -------------------------------------------------------- > > Key: ACCUMULO-2877 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2877 > Project: Accumulo > Issue Type: Improvement > Affects Versions: 1.5.1, 1.6.0 > Reporter: Bill Havanki > Assignee: Anson Liu > Priority: Trivial > Labels: newbie, summit2014 > Fix For: 1.5.2, 1.6.1, 1.7.0 > > Attachments: ACCUMULO-2877.patch, ACCUMULO-2877.patch > > > The method {{CachedConfiguration.setInstance()}} is a public static method but is never used outside the class. It should be hidden or removed. -- This message was sent by Atlassian JIRA (v6.2#6252)