Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2BF991024E for ; Fri, 13 Jun 2014 01:33:03 +0000 (UTC) Received: (qmail 25948 invoked by uid 500); 13 Jun 2014 01:33:02 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 25841 invoked by uid 500); 13 Jun 2014 01:33:02 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 25700 invoked by uid 99); 13 Jun 2014 01:33:02 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jun 2014 01:33:02 +0000 Date: Fri, 13 Jun 2014 01:33:02 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-2663) Remove usage of String#split from Combiner#init MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14030140#comment-14030140 ] ASF subversion and git services commented on ACCUMULO-2663: ----------------------------------------------------------- Commit a3a86412bcb00bb9ba68192c9425a026072e3562 in accumulo's branch refs/heads/1.5.2-SNAPSHOT from [~dmprotz] [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=a3a8641 ] ACCUMULO-2663 - Remove usage of String#split from Combiner#init Noticed that inside Combiner#init, the comma-separated list of columns is split out using the inefficient String#split method. This should be switched into something that doesn't used Regexs since this method is invoked a surprising amount in normal usage. Signed-off-by: Josh Elser > Remove usage of String#split from Combiner#init > ----------------------------------------------- > > Key: ACCUMULO-2663 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2663 > Project: Accumulo > Issue Type: Improvement > Reporter: Josh Elser > Assignee: David Protzman > Priority: Minor > Labels: newbie, summit2014 > Fix For: 1.5.2, 1.6.1, 1.7.0 > > Attachments: ACCUMULO-2663.v1.patch > > > Noticed that inside {{Combiner#init}}, the comma-separated list of columns is split out using the inefficient {{String#split}} method. This should be switched into something that doesn't used Regexs since this method is invoked a surprising amount in normal usage. -- This message was sent by Atlassian JIRA (v6.2#6252)