accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ACCUMULO-2910) Ineffective null check for replicationSources in Mutation#write()
Date Sun, 15 Jun 2014 01:24:01 GMT
Ted Yu created ACCUMULO-2910:
--------------------------------

             Summary: Ineffective null check for replicationSources in Mutation#write()
                 Key: ACCUMULO-2910
                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2910
             Project: Accumulo
          Issue Type: Bug
            Reporter: Ted Yu
            Priority: Minor


{code}
    if (!replicationSources.isEmpty()) {
      // Use 2nd least-significant bit for whether or not we have replication sources
      hasValues = (byte) (0x02 | hasValues);
    }
...
    if (0x02 == (0x02 & hasValues)) {
      if (null == replicationSources) {
{code}
The null check in 'if (0x02' block is ineffective - replicationSources was dereferenced earlier.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message