accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2877) CachedConfiguration.setInstance never used outside class
Date Thu, 26 Jun 2014 20:35:27 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14045124#comment-14045124
] 

Josh Elser commented on ACCUMULO-2877:
--------------------------------------

bq. If the client API does not call CachedConfiguration, then the method is not necessary.
We could re-open ACCUMULO-43.

Would it make sense for public API methods that interact directly with HDFS ({{TableOperationsImpl#importDirectory}})
to accept a Configuration object? We could add that support moving forward, deprecate the
version that relies on CachedConfiguration, and then have a clear time when we can remove
CachedConfiguration. It looks like OfflineScanner could also benefit from the same approach
(although we could create a Configuration with the relevant information from accumulo-site.xml
too).

> CachedConfiguration.setInstance never used outside class
> --------------------------------------------------------
>
>                 Key: ACCUMULO-2877
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2877
>             Project: Accumulo
>          Issue Type: Improvement
>    Affects Versions: 1.5.1, 1.6.0
>            Reporter: Bill Havanki
>            Assignee: Anson Liu
>            Priority: Trivial
>              Labels: newbie, summit2014
>             Fix For: 1.5.2, 1.6.1, 1.7.0
>
>         Attachments: ACCUMULO-2877.patch, ACCUMULO-2877.patch
>
>
> The method {{CachedConfiguration.setInstance()}} is a public static method but is never
used outside the class. It should be hidden or removed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message