accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2877) CachedConfiguration.setInstance never used outside class
Date Wed, 18 Jun 2014 22:22:26 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036541#comment-14036541
] 

Bill Havanki commented on ACCUMULO-2877:
----------------------------------------

Quick survey: {{MockInstance}} uses {{CachedConfiguration}} although it immediately changes
it to use the local file system. {{OfflineScanner}} and {{TableOperationsImpl}} both use it
(for locating files to scan and import, resp.), although they are in an "impl" subpackage
and therefore not part of the public API. Back in 1.5.x, {{ZooKeeperInstance}} used it but
that code was apparently moved out, belonging in the server code.

> CachedConfiguration.setInstance never used outside class
> --------------------------------------------------------
>
>                 Key: ACCUMULO-2877
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2877
>             Project: Accumulo
>          Issue Type: Improvement
>    Affects Versions: 1.5.1, 1.6.0
>            Reporter: Bill Havanki
>            Assignee: Anson Liu
>            Priority: Trivial
>              Labels: newbie, summit2014
>             Fix For: 1.5.2, 1.6.1, 1.7.0
>
>         Attachments: ACCUMULO-2877.patch, ACCUMULO-2877.patch
>
>
> The method {{CachedConfiguration.setInstance()}} is a public static method but is never
used outside the class. It should be hidden or removed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message