accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Newton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2877) CachedConfiguration.setInstance never used outside class
Date Mon, 16 Jun 2014 12:48:01 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14032397#comment-14032397
] 

Eric Newton commented on ACCUMULO-2877:
---------------------------------------

I know of at least one user that calls {{setInstance}} because they do not load their hadoop
information using the classpath.

They are using the AccumuloOutputFormat and write to HDFS.  There's no way for them to specify
their filesystem since the client code assumes the ability to load a Configuration from the
classpath.  Calling {{setInstance}} allows them to provide the configuration through external
means.

Please do not remove this method.

> CachedConfiguration.setInstance never used outside class
> --------------------------------------------------------
>
>                 Key: ACCUMULO-2877
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2877
>             Project: Accumulo
>          Issue Type: Improvement
>    Affects Versions: 1.5.1, 1.6.0
>            Reporter: Bill Havanki
>            Assignee: Anson Liu
>            Priority: Trivial
>              Labels: newbie, summit2014
>             Fix For: 1.5.2
>
>         Attachments: ACCUMULO-2877.patch, ACCUMULO-2877.patch
>
>
> The method {{CachedConfiguration.setInstance()}} is a public static method but is never
used outside the class. It should be hidden or removed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message