accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Havanki (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ACCUMULO-2854) Bad null check in BulkImport.createNewBulkDir()
Date Tue, 03 Jun 2014 17:08:05 GMT
Bill Havanki created ACCUMULO-2854:
--------------------------------------

             Summary: Bad null check in BulkImport.createNewBulkDir()
                 Key: ACCUMULO-2854
                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2854
             Project: Accumulo
          Issue Type: Bug
          Components: master
    Affects Versions: 1.6.0
            Reporter: Bill Havanki
             Fix For: 1.6.1


At the beginning of {{createNewBulkDir}} in {{o.a.a.master.tableOps.BulkImport}}:

{code}
    String tableDir = fs.matchingFileSystem(new Path(sourceDir), ServerConstants.getTablesDirs()).toString();
    
    if (tableDir == null)
      throw new IllegalStateException(sourceDir + " is not in a known namespace");
{code}

The call to {{matchingFileSystem()}} can return null, and if it does, a NullPointerException
will be thrown. {{toString()}} on a non-null result will not return null, so the null check
has no effect.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message