accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2663) Remove usage of String#split from Combiner#init
Date Fri, 13 Jun 2014 01:33:02 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14030140#comment-14030140
] 

ASF subversion and git services commented on ACCUMULO-2663:
-----------------------------------------------------------

Commit a3a86412bcb00bb9ba68192c9425a026072e3562 in accumulo's branch refs/heads/1.5.2-SNAPSHOT
from [~dmprotz]
[ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=a3a8641 ]

ACCUMULO-2663 - Remove usage of String#split from Combiner#init

Noticed that inside Combiner#init, the comma-separated list of columns is split out using
the inefficient String#split method. This should be switched into something that doesn't used
Regexs since this method is invoked a surprising amount in normal usage.

Signed-off-by: Josh Elser <elserj@apache.org>


> Remove usage of String#split from Combiner#init
> -----------------------------------------------
>
>                 Key: ACCUMULO-2663
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2663
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Josh Elser
>            Assignee: David Protzman
>            Priority: Minor
>              Labels: newbie, summit2014
>             Fix For: 1.5.2, 1.6.1, 1.7.0
>
>         Attachments: ACCUMULO-2663.v1.patch
>
>
> Noticed that inside {{Combiner#init}}, the comma-separated list of columns is split out
using the inefficient {{String#split}} method. This should be switched into something that
doesn't used Regexs since this method is invoked a surprising amount in normal usage.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message