accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2041) refactor Tablet
Date Tue, 03 Jun 2014 18:51:03 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016982#comment-14016982
] 

ASF subversion and git services commented on ACCUMULO-2041:
-----------------------------------------------------------

Commit 459d3048eb39650ebff2c93734d2886a9d4869c7 in accumulo's branch refs/heads/master from
[~ecn]
[ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=459d304 ]

ACCUMULO-2041 more review updates


> refactor Tablet
> ---------------
>
>                 Key: ACCUMULO-2041
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2041
>             Project: Accumulo
>          Issue Type: Bug
>          Components: tserver
>            Reporter: Eric Newton
>            Assignee: Eric Newton
>             Fix For: 1.7.0
>
>         Attachments: ACCUMULO-2041-v1.patch, ACCUMULO-2041-v2.patch
>
>
> Tablet has some very delicate state stored in several variables.  Translate this into
some sort of sane state machine, with appropriate, clean log messages when the state transitions.
 I'm specifically thinking of {{closing}}, {{closed}}, {{closeComplete}} and {{closeCompleting}}.
 That's 16 possible states, but I'm thinking that only a few make any sense.  May want to
look at the {{...InProgress}} and {{..WaitingToStart}} booleans, too.  Some of the embedded
classes could be moved out to their own files, just to reduce the size of the class.  There
are 17 uses of the keyword {{class}} in this one file. The constructor nesting is pretty crazy.
 The constructor is doing too much.  It should not be doing recovery, for example.  It should
not be passing "this" to anything.  Small things, like {{extent}}, {{fs}}, {{conf}} should
be final.  Anything that would facilitate unit testing would be welcome.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message