Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Tue, 6 May 2014 20:28:16 +0000 (UTC)
From: "Christopher Tubbs (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12712664.1399407361600.238639.1399408096753@arcas>
In-Reply-To: <JIRA.12712664.1399407361600@arcas>
References: <JIRA.12712664.1399407361600@arcas>
Subject: [jira] [Commented] (ACCUMULO-2781) Unit tests should reuse forks by
 default
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ACCUMULO-2781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13991086#comment-13991086 ] 

Christopher Tubbs commented on ACCUMULO-2781:
---------------------------------------------

This issue relates to ACCUMULO-2774, because if a minimum heap size is set in the surefire plugin's configuration, it will affect every JVM launched. This is particularly a problem if forkCount is ever set to something greater than 1. However, it may also affect things, even with forkCount=1, depending on the OS's ability to manage resources with forked processes. Ensuring that forked JVMs are reused (even when there is only one fork), ensures we reserve the minimum heap necessary to run the tests as few times as needed.

> Unit tests should reuse forks by default
> ----------------------------------------
>
>                 Key: ACCUMULO-2781
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2781
>             Project: Accumulo
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.6.0
>            Reporter: Christopher Tubbs
>             Fix For: 1.6.1, 1.7.0
>
>
> The default value for maven-surefire-plugin's reuseForks is true. This is set to false in our pom.xml in order to keep ITs independent. This inadvertently affects unit tests also, and causes unit tests to create a new JVM for each test class.
> These should be separated, and the default for unit tests (maven-surefire-plugin's execution) should be {{reuseForks=true}}, and the default for ITs (maven-failsafe-plugin's execution) should be {{reuseForks=false}} (as it is now).


--
This message was sent by Atlassian JIRA
(v6.2#6252)