accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2825) WholeRowIterator should be extendable
Date Mon, 19 May 2014 19:51:38 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002243#comment-14002243
] 

ASF GitHub Bot commented on ACCUMULO-2825:
------------------------------------------

Github user joshelser commented on the pull request:

    https://github.com/apache/accumulo/pull/7#issuecomment-43547788
  
    @ryaneleary I know you had mentioned that you wanted this abstraction point for a reason,
but I don't recall what it was. Can you elaborate on the types of operations that this abstract
class provides, some use case that the WholeRowIterator didn't sufficiently provide, and,
if you have it, maybe an example class?
    
    That might help cement this for when/why a user would want to extend RowEncodingIterator


> WholeRowIterator should be extendable
> -------------------------------------
>
>                 Key: ACCUMULO-2825
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2825
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 1.5.1, 1.6.0
>            Reporter: Ryan Leary
>            Assignee: Ryan Leary
>            Priority: Minor
>             Fix For: 1.6.1, 1.7.0
>
>         Attachments: add_encode_row_iterator.patch
>
>
> It would be useful to be able to choose encodings other than what is implemented already
in WholeRowIterator's encodeRow and decodeRow public static final methods.
> As an example, I wrote an iterator that reads in CQ/val pairs and automatically populates
a protocol buffer. To do this, however, I essentially copy/pasted all of the WholeRowIterator
source and changed the encode/decode methods.
> In the interest of not changing the WholeRowIterator API in any meaningful way (hopefully
meaning this improvement could be added to 1.6.1), I have created a new abstract iterator:
RowEncodingIterator, which WholeRowIterator now extends, implementing rowEncoder and rowDecoder.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message