accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2825) WholeRowIterator should be extendable
Date Sun, 18 May 2014 01:13:14 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000939#comment-14000939
] 

ASF GitHub Bot commented on ACCUMULO-2825:
------------------------------------------

GitHub user ryaneleary opened a pull request:

    https://github.com/apache/accumulo/pull/7

    ACCUMULO-2825 Add RowEncodingIterator

    The WholeRowIterator now extends the abstract RowEncodingIterator.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ryaneleary/accumulo ACCUMULO-2825

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #7
    
----
commit 73a9e6cfcad6c836ed9eb95421bc7306037739a9
Author: Ryan Leary <rleary@bbn.com>
Date:   2014-05-18T01:03:03Z

    ACCUMULO-2825 Add RowEncodingIterator
    
    The WholeRowIterator now extends the abstract RowEncodingIterator

----


> WholeRowIterator should be extendable
> -------------------------------------
>
>                 Key: ACCUMULO-2825
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2825
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 1.5.1, 1.6.0
>            Reporter: Ryan Leary
>            Assignee: Ryan Leary
>            Priority: Minor
>             Fix For: 1.6.1, 1.7.0
>
>         Attachments: add_encode_row_iterator.patch
>
>
> It would be useful to be able to choose encodings other than what is implemented already
in WholeRowIterator's encodeRow and decodeRow public static final methods.
> As an example, I wrote an iterator that reads in CQ/val pairs and automatically populates
a protocol buffer. To do this, however, I essentially copy/pasted all of the WholeRowIterator
source and changed the encode/decode methods.
> In the interest of not changing the WholeRowIterator API in any meaningful way (hopefully
meaning this improvement could be added to 1.6.1), I have created a new abstract iterator:
RowEncodingIterator, which WholeRowIterator now extends, implementing rowEncoder and rowDecoder.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message