accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Mackrory (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-2812) Support more architectures when compiling native lib
Date Fri, 16 May 2014 14:50:22 GMT


Sean Mackrory commented on ACCUMULO-2812:

+1 (non-binding) overall - I think your assumption that users are building on the target system
is safe default behavior. I would suggest changing the shell command so that only variables
named exactly USERFLAGS get matched and not variables that might contain USERFLAGS as a substring
(as rare as that might be): {code}env | grep "^USERFLAGS=" | cut -d= -f2{code}

> Support more architectures when compiling native lib
> ----------------------------------------------------
>                 Key: ACCUMULO-2812
>                 URL:
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: native
>    Affects Versions: 1.6.0
>            Reporter: Christopher Tubbs
>            Assignee: Christopher Tubbs
>              Labels: newbie
>             Fix For: 1.6.1, 1.7.0
>         Attachments: ACCUMULO-2812.v1.patch
> Since we're no longer pre-building the native maps for distribution, and instead packaging
a tiny C project to make it easier for users to create their own, it does not make sense for
the Makefile to specify a specific architecture.
> Rather, it makes more sense that the Makefile that is packaged not specify the target
architecture and instead rely on the current system architecture instead.
> I think all this would require is to drop -m64 from the CXXFLAGS, which seems fine for
Linux. I'm not sure if this has any unintended side-effects for other systems, such as Mac.

This message was sent by Atlassian JIRA

View raw message