accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2786) Jetty / servlet JARs not packaged for monitor
Date Sun, 11 May 2014 18:17:15 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13994634#comment-13994634
] 

Christopher Tubbs commented on ACCUMULO-2786:
---------------------------------------------

I'm not sure it hurts much to include it, except in terms of file size, and the fact we may
be bundling redundant jars. I see this as somewhat downstream packaging problem, and not an
actual bug of any sort. As far as I know, Accumulo works perfectly fine without packaging
these, when including all the jars from $HADOOP_HOME from nearly all Apache Hadoop binary
tarballs, because it pulls them in from Hadoop's lib directory. So, technically, they aren't
needed to include.

If we decide they are needed, I think it might be worth having a discussion on the dev list
about what strategy we're trying to follow when bundling the community bin tarball... when
to include and when not to include. The precedent has been: if vanilla Apache Hadoop provides
it in its bin tarball, we don't need to. I'm fine with changing that practice, but we should
figure out what the new standard should be before taking action on this issue.

Additionally, regarding Jetty specifically, if we're intent on packaging our own Jetty dependencies,
we've really got to move away from the old mortbay versions and on to the newer org.eclipse
ones, with version 9, to ease downstream packaging and integration. The *only* reason we're
still using mortbay, is because we were relying on the Hadoop packaged mortbay version (otherwise,
I'd have upgraded that Jetty code long ago), and that's why we were expecting it to be provided
by Hadoop and not packaging our own.

> Jetty / servlet JARs not packaged for monitor
> ---------------------------------------------
>
>                 Key: ACCUMULO-2786
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2786
>             Project: Accumulo
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.6.0
>            Reporter: Bill Havanki
>            Assignee: Christopher Tubbs
>            Priority: Minor
>              Labels: assembly, jetty, package
>         Attachments: ACCUMULO-2786.v1.patch.txt
>
>
> The monitor needs Jetty (and, transitively, the servlet API) to run. The tarball generated
by {{mvn -P assemble package}} does not include Jetty, so an installation needs to get it
from elsewhere.
> ACCUMULO-2301 was the first attempt at fixing this, and it works for 1.4 and 1.5, but
it appears that the change didn't make it to 1.6.
> A workaround is to hand-copy the Jetty and servlet JARs to Accumulo's lib directory,
or add a location where Jetty already exists to the Accumulo classpath.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message