accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2758) LocalityGroupUtil.encodeColumnFamily() ignores offset parameter
Date Fri, 16 May 2014 10:59:47 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999232#comment-13999232
] 

Josh Elser commented on ACCUMULO-2758:
--------------------------------------

The patch contents look better. Good catch on keeping the length argument, otherwise you might
run into uninitialized data from the underlying byte array with Text.

I'm not sure what you mean by a good patch. The contributor guideline I linked to should give
you step by step instructions on how to create a patch. You should make your changes. Make
a commit, which references this ticket and has a meaningful commit message, and then run {{git
format-patch HEAD^}} to create a patch from that commit you just made.

I'm not too concerned with this for the first pass as I can manually add the git metadata,
but, for future tickets, you should make the effort to submit patches in the proper format.

> LocalityGroupUtil.encodeColumnFamily() ignores offset parameter
> ---------------------------------------------------------------
>
>                 Key: ACCUMULO-2758
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2758
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.4.5, 1.5.1
>            Reporter: Bill Havanki
>            Assignee: Gary Singh
>            Priority: Minor
>              Labels: newbie
>             Fix For: 1.5.2, 1.6.1, 1.7.0
>
>         Attachments: ACCUMULO-2758-2.patch, ACCUMULO-2758.patch
>
>
> The method {{LocalityGroupUtil.encodeColumnFamily(ByteSequence)}} heeds the current offset
and length of the byte sequence, passing them to an private method that does the encoding.
However, the private method ignores its offset parameter, and always starts from the beginning
of the byte array.
> Fortunately, it appears that there are no callers for the public method, and the other
caller of the private method always passes an offset of zero. So, the bug is probably not
expressed. The method with the bug should probably just be eliminated.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message