accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Singh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2758) LocalityGroupUtil.encodeColumnFamily() ignores offset parameter
Date Fri, 16 May 2014 10:59:39 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999221#comment-13999221
] 

Gary Singh commented on ACCUMULO-2758:
--------------------------------------

Josh, 

I didn't remove the encodeColumnFamily method as there was another method using it. I removed
the references to the offset though. Let me know if the ACCUMULO-2758-2.patch works. 
Also, as I'm new and have not used Git before, can you please give me an example of a good
patch? There isn't an example on the contributor guidelines page. 

> LocalityGroupUtil.encodeColumnFamily() ignores offset parameter
> ---------------------------------------------------------------
>
>                 Key: ACCUMULO-2758
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2758
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.4.5, 1.5.1
>            Reporter: Bill Havanki
>            Assignee: Gary Singh
>            Priority: Minor
>              Labels: newbie
>             Fix For: 1.5.2, 1.6.1, 1.7.0
>
>         Attachments: ACCUMULO-2758-2.patch, ACCUMULO-2758.patch
>
>
> The method {{LocalityGroupUtil.encodeColumnFamily(ByteSequence)}} heeds the current offset
and length of the byte sequence, passing them to an private method that does the encoding.
However, the private method ignores its offset parameter, and always starts from the beginning
of the byte array.
> Fortunately, it appears that there are no callers for the public method, and the other
caller of the private method always passes an offset of zero. So, the bug is probably not
expressed. The method with the bug should probably just be eliminated.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message