Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CB84B102EE for ; Thu, 3 Apr 2014 08:47:21 +0000 (UTC) Received: (qmail 12708 invoked by uid 500); 3 Apr 2014 08:47:20 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 12616 invoked by uid 500); 3 Apr 2014 08:47:17 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 12591 invoked by uid 99); 3 Apr 2014 08:47:15 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Apr 2014 08:47:15 +0000 Date: Thu, 3 Apr 2014 08:47:15 +0000 (UTC) From: "Sean Busbey (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (ACCUMULO-2619) Review use of Cloneable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Sean Busbey created ACCUMULO-2619: ------------------------------------- Summary: Review use of Cloneable Key: ACCUMULO-2619 URL: https://issues.apache.org/jira/browse/ACCUMULO-2619 Project: Accumulo Issue Type: Improvement Reporter: Sean Busbey Priority: Minor We have a few places that claim cloneable, including in the public API. Go through and bring them in line with Effective Java. Note that this means where possible we should favor a copy constructor to using the clone method, since it is fundamentally broken. Where we must have it we need to make sure we obey all the rules. # return the type of the class implementing Cloneable # do not throw CloneNotSupportedException # make sure to return the result of super.clone() (unless the class is final) # any fields that are not safe to share between an object and its clone must be deep copied after using super.clone(). -- This message was sent by Atlassian JIRA (v6.2#6252)