accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2721) Combine several SimpleMacIT tests to share a MAC
Date Wed, 23 Apr 2014 15:22:15 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978296#comment-13978296
] 

Christopher Tubbs commented on ACCUMULO-2721:
---------------------------------------------

I had made some attempt to use a shared instance that spun up in the pre-integration-test
phase, so each SimpleMacITs wouldn't start up their own MAC, but it didn't work well with
forking.

I see three classes of MAC-based ITs:

# Those that can reuse the same instance.
# Those that need their own because of potential interference, but don't need special config
(SimpleMacIT, currently).
# Those that need to customize their MAC to test for special circumstances (ConfigurableMacIT).

What I wouldn't want to do, though, is just throw a bunch of tests into the same class file,
just to re-use the same instance. That makes it harder to analyze and understand test coverage.

> Combine several SimpleMacIT tests to share a MAC
> ------------------------------------------------
>
>                 Key: ACCUMULO-2721
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2721
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: test
>            Reporter: Mike Drob
>            Priority: Critical
>             Fix For: 1.7.0
>
>
> Each SimpleMacIT class spins up its own MAC. Theoretically, many of them can share one,
and make the tests run faster.
> We can look at using a {{Suite}} or {{ExternalResource}} or there's like a million ways
to do this.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message