accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (ACCUMULO-2696) Master has misleading log message in case of failure for status thread
Date Fri, 18 Apr 2014 16:15:15 GMT

     [ https://issues.apache.org/jira/browse/ACCUMULO-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sean Busbey updated ACCUMULO-2696:
----------------------------------

    Description: 
the status thread is a worker within the Master that handles internal state transitions. It
contains this handler in a catch-all block to ensure it keeps working:

{noformat}
        } catch (Throwable t) {
          log.error("Error balancing tablets", t);
          UtilWaitThread.sleep(WAIT_BETWEEN_ERRORS);
        }
{noformat}

while balancing does happen in this thread (in a call to updateStatus before this catch),
the try block encompasses a great deal of additional code. so this message can be misleading
about where to look for problems. It should be updated to state that there was a problem iwth
transitioning states and should probably indicate both that it will retry and how long it
will pause before doing so.

  was:
the status thread is a worker within the Master that handles internal state transitions. It
contains this handler in a catch-all block to ensure it keeps working:

{noformat}
        } catch (Throwable t) {
          log.error("Error balancing tablets", t);
          UtilWaitThread.sleep(WAIT_BETWEEN_ERRORS);
        }
{noformat}

No balancing happens in this thread, so this message is misleading about where to look for
problems. It should be updated to state that there was a problem iwth transitioning states
and should probably indicate both that it will retry and how long it will pause before doing
so.


> Master has misleading log message in case of failure for status thread
> ----------------------------------------------------------------------
>
>                 Key: ACCUMULO-2696
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2696
>             Project: Accumulo
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 1.4.0, 1.5.0, 1.6.0
>            Reporter: Sean Busbey
>            Priority: Minor
>              Labels: logging, newbie
>             Fix For: 1.6.1, 1.7.0
>
>
> the status thread is a worker within the Master that handles internal state transitions.
It contains this handler in a catch-all block to ensure it keeps working:
> {noformat}
>         } catch (Throwable t) {
>           log.error("Error balancing tablets", t);
>           UtilWaitThread.sleep(WAIT_BETWEEN_ERRORS);
>         }
> {noformat}
> while balancing does happen in this thread (in a call to updateStatus before this catch),
the try block encompasses a great deal of additional code. so this message can be misleading
about where to look for problems. It should be updated to state that there was a problem iwth
transitioning states and should probably indicate both that it will retry and how long it
will pause before doing so.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message