accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Vines (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2669) NoFlushOutputStream always in use in DfsLogger
Date Thu, 17 Apr 2014 15:00:29 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973002#comment-13973002
] 

John Vines commented on ACCUMULO-2669:
--------------------------------------

The NoFlushOutputStream needs to be a permanent fixture in order to support the flush() calls
in write(). The penalty we would pay to check if we should call flush() on every write(),
I believe, would outweigh the cost of the noop flush() call.

> NoFlushOutputStream always in use in DfsLogger
> ----------------------------------------------
>
>                 Key: ACCUMULO-2669
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2669
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.6.0
>            Reporter: Jonathan Park
>            Priority: Minor
>             Fix For: 1.6.1
>
>
> I may be misreading the implementation of DfsLogger, but it looks like we always make
use of the NoFlushOutputStream, even if encryption isn't enabled. There appears to be a faulty
check in the DfsLogger.open() implementation that I don't believe can be satisfied (line 384).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message