accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2669) NoFlushOutputStream always in use in DfsLogger
Date Mon, 14 Apr 2014 20:26:21 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968797#comment-13968797
] 

Josh Elser commented on ACCUMULO-2669:
--------------------------------------

Interestingly enough (at least to me), it appears that DFSOutputStream doesn't actually implement
flush() -- it's still the noop implementation from java.io.OutputStream. I believe that means
that, although this isn't working as originally intended, it shouldn't be cause any regression
(besides the minimal overhead of invoking a noop method).

Best as I can tell, we should clean this up, but this doesn't need to be put in 1.6.0.

> NoFlushOutputStream always in use in DfsLogger
> ----------------------------------------------
>
>                 Key: ACCUMULO-2669
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2669
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.6.0
>            Reporter: Jonathan Park
>            Priority: Minor
>
> I may be misreading the implementation of DfsLogger, but it looks like we always make
use of the NoFlushOutputStream, even if encryption isn't enabled. There appears to be a faulty
check in the DfsLogger.open() implementation that I don't believe can be satisfied (line 384).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message