accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2619) Review use of Cloneable
Date Fri, 04 Apr 2014 14:08:18 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959981#comment-13959981
] 

Christopher Tubbs commented on ACCUMULO-2619:
---------------------------------------------

Since this issue is essentially superceded by doing the right thing in ACCUMULO-2589, and
because it's low priority, I don't think it should be done for 1.6.0.

> Review use of Cloneable
> -----------------------
>
>                 Key: ACCUMULO-2619
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2619
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Sean Busbey
>            Priority: Minor
>
> We have a few places that claim cloneable, including in the public API. Go through and
bring them in line with Effective  Java.
> Note that this means where possible we should favor a copy constructor to using the clone
method, since it is fundamentally broken.
> Where we must have it we need to make sure we obey all the rules.
> # return the type of the class implementing Cloneable
> # do not throw CloneNotSupportedException
> # make sure to return the result of super.clone() (unless the class is final)
> # any fields that are not safe to share between an object and its clone must be deep
copied after using super.clone().



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message