Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7A40B10DF4 for ; Tue, 25 Mar 2014 07:38:54 +0000 (UTC) Received: (qmail 9727 invoked by uid 500); 25 Mar 2014 07:38:51 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 9672 invoked by uid 500); 25 Mar 2014 07:38:47 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 9433 invoked by uid 99); 25 Mar 2014 07:38:43 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Mar 2014 07:38:43 +0000 Date: Tue, 25 Mar 2014 07:38:43 +0000 (UTC) From: "Sean Busbey (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Issue Comment Deleted] (ACCUMULO-2544) Incorrect boundry matching for MockTableOperations.deleteRows MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated ACCUMULO-2544: ---------------------------------- Comment: was deleted (was: Sorry, Mike Drob I fat fingered you name. No Disrespect) > Incorrect boundry matching for MockTableOperations.deleteRows > ------------------------------------------------------------- > > Key: ACCUMULO-2544 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2544 > Project: Accumulo > Issue Type: Bug > Components: test > Affects Versions: 1.6.1 > Environment: Mac OS Mavericks; java 7 > Reporter: Mike Fagan > Assignee: Mike Fagan > Labels: mock, newbie, patch > Fix For: 1.6.0 > > Attachments: ACCUMULO-2544.patch, ACCUMULO-2544.patch > > > The api for deleteRows specifies: Delete rows between (start, end] but the current implementation for MockTableOperations.deleteRows is implemented as (start, end) > Here is the failing test case > {code:java} > public class TestDelete { > private static final String INSTANCE = "mock"; > private static final String TABLE = "foo"; > private static final String USER = "user"; > private static final String PASS = "password"; > private static final Authorizations AUTHS = new Authorizations(); > @Test > public void testDelete() throws TableNotFoundException, AccumuloException, > AccumuloSecurityException, TableExistsException { > MockInstance mockAcc = new MockInstance(INSTANCE); > Connector conn = mockAcc.getConnector(USER, new PasswordToken(PASS)); > conn.tableOperations().create(TABLE); > conn.securityOperations().grantTablePermission(USER, TABLE, TablePermission.READ); > conn.securityOperations().grantTablePermission(USER, TABLE, TablePermission.WRITE); > Mutation mut = new Mutation("2"); > mut.put("colfam", "colqual", "value"); > BatchWriter writer = conn.createBatchWriter(TABLE, new BatchWriterConfig()); > writer.addMutation(mut); > Scanner scan = conn.createScanner(TABLE, AUTHS); > scan.setRange(new Range("2", "2")); > assertEquals(1, countRecords(scan)); > > // this should delete (1,2] > conn.tableOperations().deleteRows(TABLE, new Text("1"), new Text("2")); > scan = conn.createScanner(TABLE, AUTHS); > scan.setRange(new Range("2", "2")); > > // this will fail if row 2 exists > assertEquals(0, countRecords(scan)); > } > private int countRecords(Scanner scan) { > int cnt = 0; > for (Entry entry : scan) { > cnt++; > } > scan.close(); > return cnt; > } > } > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)