Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Wed, 19 Mar 2014 22:14:44 +0000 (UTC)
From: "John Vines (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12702384.1395237889688.106788.1395267284692@arcas>
In-Reply-To: <JIRA.12702384.1395237889688@arcas>
References: <JIRA.12702384.1395237889688@arcas>
Subject: [jira] [Commented] (ACCUMULO-2497) InstanceFactory
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ACCUMULO-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941074#comment-13941074 ] 

John Vines commented on ACCUMULO-2497:
--------------------------------------

A. I'm not great with mocking, so pardon my ignorance. But couldn't you just as easily mock out Instance instance = new ZooKeeperInstance(...) to sub in your special Instance?

B. If this is for testing purposes, wouldn't this live solely in Test code, which means it could live in src/test/java...? I don't know where new ZooKeeperInstance is called in our standard code that would require this.

> InstanceFactory
> ---------------
>
>                 Key: ACCUMULO-2497
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2497
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>            Reporter: Bill Havanki
>            Assignee: Bill Havanki
>            Priority: Minor
>              Labels: factory, static, testability
>             Fix For: 1.6.1, 1.7.0
>
>
> Working on ACCUMULO-2470 (unit tests for server/base) is made difficult by the heavy dependence on static method calls in our architecture. This ticket is for introducing an {{InstanceFactory}} interface that will greatly ease testing of code that currently retrieves instances via static methods (e.g., {{HdfsZooInstance.getInstance()}}).
> Limitations:
> * Work here should be limited to creating {{InstanceFactory}} and its implementations, and not integrating it into existing code (yet).
> * Work is limited to 1.6 and later. To avoid perturbing the 1.6.0 release no new code may be introduced into the public API ({{Instance}} is in the public API).
> * A refactoring of the client API is being considered (see ACCUMULO-2128), so this change should not further complicate - and should hopefully help - that future effort.


--
This message was sent by Atlassian JIRA
(v6.2#6252)