Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 31464CE57 for ; Fri, 7 Mar 2014 16:28:50 +0000 (UTC) Received: (qmail 36940 invoked by uid 500); 7 Mar 2014 16:28:48 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 36915 invoked by uid 500); 7 Mar 2014 16:28:47 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 36685 invoked by uid 99); 7 Mar 2014 16:28:45 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Mar 2014 16:28:45 +0000 Date: Fri, 7 Mar 2014 16:28:45 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-2429) Shell does not clean up JLine ConsoleReader, leaks threads MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924020#comment-13924020 ] ASF subversion and git services commented on ACCUMULO-2429: ----------------------------------------------------------- Commit 8acdf534ceb92627075a1417e61c5e14790ee9d8 in accumulo's branch refs/heads/1.6.0-SNAPSHOT from [~bhavanki] [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=8acdf53 ] ACCUMULO-2429 Add shell shutdown for thread cleanup The JLine 2 ConsoleReader used by Shell spawns a thread which should be cleaned up when done with the Shell. Otherwise, the thread leaks, taking up resources when the shell is used programmatically. This commit adds a shutdown() method to Shell for cleaning up the thread. This enables ShellServerIT to pass reliably and not flood the OS with leaked threads. > Shell does not clean up JLine ConsoleReader, leaks threads > ---------------------------------------------------------- > > Key: ACCUMULO-2429 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2429 > Project: Accumulo > Issue Type: Bug > Components: shell > Reporter: Bill Havanki > Assignee: Bill Havanki > Labels: memory-leak, shell, threads > Fix For: 1.6.0, 1.7.0 > > > The shell uses the JLine {{ConsoleReader}} class. That class spawns a thread on construction (tsk-tsk) for its internal non-blocking input stream representation. If the {{ConsoleReader}} is not shut down properly, the thread keeps running. This is particularly a problem when running {{ShellServerIT}} under 1.6 and later; the JVM can run out of memory to allocate threads and fail the test. -- This message was sent by Atlassian JIRA (v6.2#6252)