Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Tue, 4 Mar 2014 15:45:22 +0000 (UTC)
From: "Mike Drob (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12697977.1393609227071.11063.1393947922319@arcas>
In-Reply-To: <JIRA.12697977.1393609227071@arcas>
References: <JIRA.12697977.1393609227071@arcas>
Subject: [jira] [Updated] (ACCUMULO-2423) Converge Shell scripts on single
 implementation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/ACCUMULO-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mike Drob updated ACCUMULO-2423:
--------------------------------

    Attachment: ACCUMULO-2423.v1.patch.txt

Attached is my first cut at implementing best practices for our shell scripts.

This patch includes the following changes:
* Standardize interpreter line on '#! /usr/bin/env foo'
* Replace `...` with $(...) in bash scripts
* Replace \[...] with \[\[...]] in bash scripts
* Replace = with == in \[\[...]] in bash scripts


> Converge Shell scripts on single implementation
> -----------------------------------------------
>
>                 Key: ACCUMULO-2423
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2423
>             Project: Accumulo
>          Issue Type: Improvement
>    Affects Versions: 1.6.0
>            Reporter: Mike Drob
>         Attachments: ACCUMULO-2423.v1.patch.txt
>
>
> Do we want to have a stated dependency on a particular shell? Most of our scripts explicitly use bash, but some use sh. Most scripts invoke {{#\!/usr/bin/env bash}} but some do {{#\!/bin/bash}} or other crazy things.
> I don't have a particular preference which way we go, but I'd like to see us standardize one way or the other.
> If we use {{/bin/sh}}, then we can run everything through the [checkbashisms|https://wiki.ubuntu.com/DashAsBinSh#I_am_a_developer._How_can_I_avoid_this_problem_in_future.3F] script (also available for other distros)
> If we go the other way, and switch everything to bash, then we can run them through {{ksh -n}} for deprecation warnings. I know that's a different shell, but they're still moderately useful.


--
This message was sent by Atlassian JIRA
(v6.2#6252)