Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 73F9810AC3 for ; Tue, 18 Mar 2014 05:11:52 +0000 (UTC) Received: (qmail 59672 invoked by uid 500); 18 Mar 2014 05:11:51 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 59622 invoked by uid 500); 18 Mar 2014 05:11:50 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 58711 invoked by uid 99); 18 Mar 2014 05:11:46 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Mar 2014 05:11:46 +0000 Date: Tue, 18 Mar 2014 05:11:46 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-2187) Scanner is left unclosed in AddSplitsCommand#execute() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938826#comment-13938826 ] ASF subversion and git services commented on ACCUMULO-2187: ----------------------------------------------------------- Commit 18fee706ba213b2cd6b0aaa587f5da1bfe5aa118 in accumulo's branch refs/heads/master from [~ctubbsii] [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=18fee70 ] ACCUMULO-2477, ACCUMULO-2187 Fix introduced warnings/formatting > Scanner is left unclosed in AddSplitsCommand#execute() > ------------------------------------------------------ > > Key: ACCUMULO-2187 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2187 > Project: Accumulo > Issue Type: Bug > Reporter: Ted Yu > Assignee: Vikram Srivastava > Priority: Minor > Labels: newbie > Fix For: 1.7.0 > > Attachments: ACCUMULO-2187.v1.patch.txt, ACCUMULO-2187.v2.patch.txt > > > Here is related code: > {code} > java.util.Scanner file = new java.util.Scanner(new File(f)); > while (file.hasNextLine()) { > line = file.nextLine(); > if (!line.isEmpty()) { > splits.add(decode ? new Text(Base64.decodeBase64(line.getBytes())) : new Text(line)); > } > } > {code} > file should be closed upon return. -- This message was sent by Atlassian JIRA (v6.2#6252)