accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2594) Improve TabletLocator.getInstance() to check tableId points to a table which exists
Date Mon, 31 Mar 2014 19:48:22 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955586#comment-13955586
] 

Josh Elser commented on ACCUMULO-2594:
--------------------------------------

Is that really relevant? It's garbage to have a class silently do the wrong thing whether
or not we explicitly expose it to users.

> Improve TabletLocator.getInstance() to check tableId points to a table which exists
> -----------------------------------------------------------------------------------
>
>                 Key: ACCUMULO-2594
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2594
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 1.5.0
>            Reporter: Ara Ebrahimi
>            Priority: Minor
>             Fix For: 1.5.2, 1.6.1
>
>
> If you pass an invalid tableId (or in my case tableName instead of tableId) TabletLocator
won't complain.
> TabletLocator tabletLocator = TabletLocator.getInstance(instance, new Text(tableId));
> Next if you use the returned tabletLocator to locate a tablet it just returns an empty
list, never complaining that the tableId was invalid:
> TabletLocator.TabletLocation tabletLocation = tabletLocator.locateTablet(rowKey.getText(),
false, false, credentials.toThrift());
> Ideally TabletLocator.getInstance() should guard against invalid/non-existing tableIds.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message